Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set HTTP User-Agent header for requests #377

Open
merkys opened this issue Nov 29, 2021 · 0 comments
Open

Set HTTP User-Agent header for requests #377

merkys opened this issue Nov 29, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@merkys
Copy link

merkys commented Nov 29, 2021

It is usually very nice when software presents itself in the HTTP User-Agent header. Web browsers almost always present themselves in a verbose but neat way. This way the server-side developers are informed about what software makes requests to their servers, and may occasionally forward common issues to the client developers. Moreover, usage statistics could be drawn at the server-size, which is nice.

voila-optimade-client seems to be using Python requests package for HTTP requests. By default its User-Agent is python-requests/<version>. Changing this seems to be rather simple. It would be nice to see voila-optimade-client/<version> at least.

If user privacy is concern, it should not be forgotten that this is F/LOSS, thus anyone concerned with their privacy are free to patch their copy of the client to their liking.

@CasperWA CasperWA self-assigned this Nov 30, 2021
@CasperWA CasperWA added the enhancement New feature or request label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants