Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whether the periodic table is shown or not should be determined by a widget trait #209

Open
CasperWA opened this issue Nov 5, 2020 · 0 comments

Comments

@CasperWA
Copy link
Owner

CasperWA commented Nov 5, 2020

Whether the table is shown or not should be determined by a widget trait "show_periodic_table_of_elements" and that trait is linked with the button.

Originally posted by @csadorf in #203 (comment)

A suggestion from #203 by @csadorf.

This makes sense to me, but to be reliable and useable, the way in which filters are invoked needs to be updated. I.e., using a trait for this in the current state will be no different than the implementation used in #203.

@CasperWA CasperWA changed the title Whether the table is shown or not should be determined by a widget trait Whether the periodic table is shown or not should be determined by a widget trait Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant