Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: provide an option for not requiring the admin role #130

Open
gao-sun opened this issue Jul 2, 2022 · 2 comments
Open

Comments

@gao-sun
Copy link
Contributor

gao-sun commented Jul 2, 2022

thank you for this amazing workflow! it's the best solution i've ever seen.

recently GitHub launched a feature that allows specific actors to bypass required pull requests:

image

so i think there's no need to require admin role since we can add the bot user to this exception.

would you like to add the option for not requiring the admin role? i would love to create a pull request but i'm not good at bash script and python at all. 😭

@CasperWA
Copy link
Owner

CasperWA commented Jul 4, 2022

Cheers 😃 Right. I'll test out this feature as it should work as intended - but there may be some checks in the action that will disallow it at this point.

Most importantly I'll update the documentation - fell free to take a stab at updating the documentation on this yourself as well with a PR 😄

@gao-sun
Copy link
Contributor Author

gao-sun commented Jul 5, 2022

coool! thanks. i'll try and update the docs if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants