Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vueunit.yml failing, check and re-enable when migrating to Vue 3 #828

Open
sampsapenna opened this issue Nov 14, 2022 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@sampsapenna
Copy link
Member

Describe the bug

vueunit.yml uses testing-library, which is no longer supported for Vue 2. This means that, if we are to update to Vue 2.7, we need to deprecate this workflow until move to Vue 3. Migrating to Vue 3 via Vue 2.7 is a simpler alternative, as 2.7 backports a lot of the features provided in Vue 3 – e.g. the composition API as built-in.

To Reproduce

Steps to reproduce the behaviour:

cd swift_browser_ui_frontend
npm i
npm test

Expected behavior

The jest tests run properly.

Screenshots

Additional context

This issue should resolve itself when we migrate to Vue 3, since the library should support it.

@sampsapenna sampsapenna added the bug Something isn't working label Nov 14, 2022
@sampsapenna sampsapenna self-assigned this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant