Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the need to use two Objenesis versions #161

Closed
CRamsan opened this issue Jan 30, 2021 · 1 comment
Closed

Remove the need to use two Objenesis versions #161

CRamsan opened this issue Jan 30, 2021 · 1 comment
Assignees
@CRamsan
Labels
project_framework Core Framework project_tooling Tools and Infrastructure
Projects
April Sprint

Comments

@CRamsan
Copy link
Owner

CRamsan commented Jan 30, 2021

There are problems with Objenesis and support for the latest versions of Android. This is documented in mockk/mockk#281

I just want to add a remark to this issue.

This thing with 1.9.3 happened by accident. It was a merged PR that was not properly tested (as one reason is because of the lack of automation for the instrumented tests). So big sorry regarding this trouble.

Recently for version 1.10.0, I was fighting not to raise minSdkVersion.
The trick was to use old Objenesis as a dependency for instrumented tests and new Objenesis for everything else (JVM/Android unit test). And this time I devoted quite a lot of time to testing.

We will need to follow up with the development of Objenesis and Mockk to verify when we can remove the current workaround.

Other upstream related issues:
@CRamsan CRamsan added project_tooling Tools and Infrastructure project_framework Core Framework labels Jan 30, 2021
@CRamsan CRamsan self-assigned this Jan 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2021

Stale issue message

@CRamsan CRamsan added this to To do in April Sprint Apr 8, 2021
@CRamsan CRamsan closed this as completed May 28, 2021
April Sprint automation moved this from To do to Done May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CRamsan CRamsan

Labels
project_framework Core Framework project_tooling Tools and Infrastructure
Projects
No open projects
April Sprint
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CRamsan