Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt/Fix Unit Tests for the Test Suite "frontend_html" #79

Closed
muratpurc opened this issue Nov 26, 2019 · 3 comments
Closed

Adapt/Fix Unit Tests for the Test Suite "frontend_html" #79

muratpurc opened this issue Nov 26, 2019 · 3 comments
Assignees
@muratpurc
Labels
bug Something isn't working enhancement New feature or request
Projects
Kanban board
Milestone
v4.10.2

Comments

@muratpurc
Copy link
Collaborator

Replace usage of missing Util::callProtectedMethod against proper implementation. Usage of Assert::readAttribute is deprecated, replace this also against a proper implementation.

Some of the unit test will fail, since we have an internal counter for the id-attribute in cHTML, this means, that a creation of an element will set an id-attribute value, which is not empty, like it was in the past. Handle this in unit tests.
@muratpurc muratpurc added bug Something isn't working enhancement New feature or request labels Nov 26, 2019
@muratpurc muratpurc added this to the v4.10.2 milestone Nov 26, 2019
@muratpurc muratpurc self-assigned this Nov 26, 2019
@muratpurc muratpurc added this to To do in Kanban board via automation Nov 26, 2019
@gonatan
Copy link
Collaborator

gonatan commented Nov 26, 2019 •
edited

Usage of Assert::readAttribute is deprecated, replace this also against a proper implementation.

I've seen that and finally understood that some of my tests using this method are complete nonsense. So feel free to remove them instead of trying to adapt them.

muratpurc added a commit that referenced this issue Nov 27, 2019
@muratpurc
#79 Adapt/Fix Unit Tests for the Test Suite "frontend_html".
ee61f03
@muratpurc muratpurc mentioned this issue Nov 27, 2019
Merged
@muratpurc
Copy link
Collaborator Author

The change for this issue was committet to another branch, see ee61f03.

@muratpurc
Copy link
Collaborator Author

Description of this issue has been moved to #78, closing this issue.

Kanban board automation moved this from To do to Done Nov 27, 2019
gonatan pushed a commit that referenced this issue Nov 27, 2019
@muratpurc @gonatan
#78 Fix classes who extend from cHTMLFormElement and cHTMLContentElem… (
4c97ce9 
#80)

* #78 Fix classes who extend from cHTMLFormElement and cHTMLContentElement.

* #79 Adapt/Fix Unit Tests for the Test Suite "frontend_html".

* #78 Typo

* Bug/#78 amendments (#81)

* hadled exception

* #78 refactored default value of tabindex in html classes, allowed -1 as tabindex according to manual, reformatted code, extended tests, refactored parsing of html element attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muratpurc muratpurc

Labels
bug Something isn't working enhancement New feature or request
Projects
Kanban board
  
Done
Milestone
v4.10.2
Development

No branches or pull requests
2 participants
@muratpurc @gonatan