Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup output for end2endup test #14401

Open
1 task
JFisk42 opened this issue May 14, 2024 · 0 comments
Open
1 task

Cleanup output for end2endup test #14401

JFisk42 opened this issue May 14, 2024 · 0 comments
Labels
platform Platform Team

Comments

@JFisk42
Copy link
Collaborator

JFisk42 commented May 14, 2024

Problem statement

Currently the input files that the test uses result in a number of warnings from "INVALID_MSG_CONDITION_MAPPING". During the test the final response from the history submission endpoint is output into the terminal. Example run: 525 lines of output from the test, ~200 lines of this are warnings. The valid_hl7_e2e.hl7 file produces 12 warnings from missing mappings and so inflates the output of the test by a lot.

What you need to know

There are two options to fix this:

  • Change the loinc codes used in the test files so that the mapping warnings are gone.
    • This may be best practice as we should be using valid data for these tests.
  • Modify the test so that the history endpoint response is only logged when there is an issue.
    • This may be preferable in the long term as there are currently 3 scenarios for this test in master with 2 more being added soon.

Acceptance criteria

  • The noisy output from the end2endup test is reduced.
@JFisk42 JFisk42 added the platform Platform Team label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform Platform Team
Projects
Development

No branches or pull requests

1 participant