hook scaffolding #14340
hook scaffolding #14340
Conversation
jpandersen87
added
the
frontend
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
...t/src/hooks/api/organizations/UseDeleteOrganizationReceiver/UseDeleteOrganizationReceiver.ts
Outdated
Show resolved
Hide resolved
penny-lischer
added
the
experience
| options, | ||
| endpointConfig, | ||
| }: StaticAuthorizedFetchProps) { | ||
| if (options.segments && !endpointConfig) |
There was a problem hiding this comment.
Do we want to log any of these potential errors to Azure?
There was a problem hiding this comment.
At the moment i'm expecting our custom error boundary to handle emitting these to telemetry.
| @@ -5,6 +5,7 @@ import { | |||
| UserClaims, | |||
| } from "@okta/okta-auth-js"; | |||
| import { useOktaAuth } from "@okta/okta-react"; | |||
| import axios, { AxiosError } from "axios"; | |||
There was a problem hiding this comment.
I understand this might be out of the scope of this PR, but we do use both fetch and axios in our project. Is it time that we hard cut to one or the other?
For example in: AdminOrgEdit.tsx AdminLastMileFailuresTable.tsx EditSenderSettings.tsx
There was a problem hiding this comment.
Yes. Axios is currently the pattern (for context, established even before me), which is why it is continuing to be used. Getting everything in the project moved to using these new hooks will naturally align the project in one direction.
|
Fixes: #14341,#8366,#8379,#8378,#8375,#8373,#8371,#8368
This PR scaffolds the (hopefully) remaining hooks to migrate to react-query.
authorizedFetchwas folded into the Session Context and now allows manual urls in addition to the endpointconfig object.