Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FHIRRouter Azure Events to Store messageID #14332

Closed
1 task
arnejduranovic opened this issue May 7, 2024 · 7 comments
Closed
1 task

Update FHIRRouter Azure Events to Store messageID #14332

arnejduranovic opened this issue May 7, 2024 · 7 comments
Assignees
Labels
blocked Issue State label to flag PRs and issues to show they are blocked platform Platform Team

Comments

@arnejduranovic
Copy link
Collaborator

arnejduranovic commented May 7, 2024

User Story

As a ReportStream developer troubleshooting issues,
I want to see the messageID alongside the reportID,
so I can more easily find the reports I am looking for

Description/Use Case

Update ReportAcceptedEvent and ReportRoutedEvent to include the messageID alongside the reportID and other info.

Risks/Impacts/Considerations

Dev Notes

Here is the mapping inventory:

Screenshot 2024-05-07 at 12 31 12 PM

Acceptance Criteria

  • ReportAcceptedEvent and ReportRoutedEvent both include messageID (Bundle.Identifier.value and Bundle.Identifier.system).
@arnejduranovic arnejduranovic added the platform Platform Team label May 7, 2024
@Andrey-Glazkv
Copy link
Collaborator

@Andrey-Glazkv
Copy link
Collaborator

Please add your planning poker estimate with Zenhub @david-navapbc

@Andrey-Glazkv
Copy link
Collaborator

Please add your planning poker estimate with Zenhub @JFisk42

@arnejduranovic arnejduranovic added the ready-for-grooming Ticket is a point where we can productively discuss it label May 13, 2024
@Andrey-Glazkv
Copy link
Collaborator

Please add your planning poker estimate with Zenhub @jack-h-wang

@arnejduranovic arnejduranovic added the blocked Issue State label to flag PRs and issues to show they are blocked label May 13, 2024
@arnejduranovic
Copy link
Collaborator Author

arnejduranovic commented May 13, 2024

@arnejduranovic this is blocked on mapping this page: https://docs.google.com/spreadsheets/d/1oOy6JW4Mv5VL8DsoA05bYZCUa1JqP4GCYNPF5GJTLxQ/edit#gid=0

Arnej to create a ticket. This is being done in EnhanceBundle function but has flaws -- remove this functionality when mappings are done. This AC should be part of new ticket:

  • Default RS mappings correctly map MSH.10 -> Bundle.Identifier -> MSH.10

@Andrey-Glazkv Andrey-Glazkv removed the ready-for-grooming Ticket is a point where we can productively discuss it label May 13, 2024
@JFisk42 JFisk42 self-assigned this May 15, 2024
@JFisk42
Copy link
Collaborator

JFisk42 commented May 24, 2024

Splitting off a new ticket for the enhancement to generate a uuid for fhir bundles that come in without an identifier.

Formerly this was included in the AC "FHIR spec says bundle.identifier is optional, create new one with generated UUID if missing via sender transform in convert step. This will give us enough info to link a message a receiver sends back to us to the original report submitted by sender."

@JFisk42
Copy link
Collaborator

JFisk42 commented May 24, 2024

@JFisk42 JFisk42 closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issue State label to flag PRs and issues to show they are blocked platform Platform Team
Projects
Development

No branches or pull requests

3 participants