Optimize build-frontend workflow #10071
Open
+354
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
snesm
requested changes
Jun 23, 2023
snesm
reviewed
May 6, 2024
| @@ -4,6 +4,11 @@ on: | |||
| pull_request: | |||
| branches: | |||
| - master | |||
| paths: | |||
There was a problem hiding this comment.
unnecessary: this is short-circuted based on changes detected via build vars
or should we move away from the using the build vars logic
There was a problem hiding this comment.
We should probably move away from doing path detection if it's simple enough to be covered using the paths property in a github action doc.
| timeout-minutes: 5 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: |
| name: Frontend CI | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
all branches (that match path)?
There was a problem hiding this comment.
Except for production, I've just made an update to fix that.
| @@ -3,7 +3,6 @@ name: Frontend | |||
| on: | |||
| pull_request: | |||
| branches: | |||
There was a problem hiding this comment.
Does this obsolete this workflow and .github/actions/build-frontend (used below)
There was a problem hiding this comment.
Currently, it does not. This only changes pull_request-based workflows (except production) as a starter. Push-based actions will still trigger the original flows as well as PRs for production. This can be applied wider after an observation period if dev-ops desires.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF ScorecardScorecard details
Scanned Manifest Files.github/workflows/frontend_chromatic_main.yml.github/workflows/chromatic-master.yml
.github/workflows/chromatic-pr.yml |
|
Branch deployed to Chromatic 🚀.
View via: |
|
penny-lischer
added
frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14324
This PR creates a dedicated
frontend_ciworkflow for pull requests within thefrontend-reactsubdirectory. Activation bypull_requestin all other workflow files for frontend have been removed with relevant tasks handled byfrontend_ci. This workflow will first lint the frontend code before running all subsequent jobs. Concurrency is enabled so that obsolete jobs are automatically cancelled.Also:
validate_resourcesby frontend paths disabledpre_jobinbuild_hubredundant with path activation so was removedchromatic_prremoved as it is built intofrontend_ci(and fixed so that TurboSnap works within PR context)chromatic_masterrenamed tofrontend_chromatic_main