Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Limit to user defined max number of rows #275

Closed
cbrittingham opened this issue Aug 5, 2019 · 1 comment
Closed

[FEATURE] Limit to user defined max number of rows #275

cbrittingham opened this issue Aug 5, 2019 · 1 comment
Assignees
@doug-martin @dustinsmith1024
Labels
enhancement

Comments

@cbrittingham
Copy link

cbrittingham commented Aug 5, 2019 •
edited

The origin of this feature was a use case where I wanted to read and process headers prior to processing the rest of the data (with the newly defined headers).

I could see other use cases where you might want to limit the amount of data read. (and perhaps a companion option to start on a given row to support some type of pagination logic)

I have a working solution that adds a maxRows option.

I plan to submit a pull request for consideration.
@cbrittingham cbrittingham changed the title [FEATURE] Limit to user defined max number of lines [FEATURE] Limit to user defined max number of rows Aug 5, 2019
cbrittingham pushed a commit to cbrittingham/fast-csv that referenced this issue Aug 5, 2019
Feature add maxRows for C2FO#275
e711954
cbrittingham pushed a commit to cbrittingham/fast-csv that referenced this issue Aug 5, 2019
Feature: add maxRows for C2FO#275
9589054
@cbrittingham cbrittingham mentioned this issue Aug 5, 2019
Closed
8 tasks
cbrittingham added a commit to cbrittingham/fast-csv that referenced this issue Aug 27, 2019
@cbrittingham
Merge pull request #1 from cbrittingham/maxLines-#275
0cc34c8 
Feature: add maxRows for C2FO#275
doug-martin added a commit that referenced this issue Dec 15, 2019
@doug-martin
MaxRows option
06eab1b 
* [ADDED] `maxRows` option to limit the number of rows parsed. #275 #277
This was referenced Dec 15, 2019
Merged
Closed
Merged
doug-martin added a commit that referenced this issue Dec 17, 2019
@doug-martin
v3.6.0
20d7a99 
* [ADDED] `maxRows` option to limit the number of rows parsed. #275 #277 - @cbrittingham
* [ADDED] `skipRows` to allow skipping parsed rows see parsing.md
* [ADDED] `skipLines` to allow skipping entire lines of a csv parsing.md #267
* Exported formatting and parsing types.
* Removed `.npmignore` in favor of `package.json` files
@doug-martin
Copy link
Member

doug-martin commented Dec 17, 2019 •
edited

Released in v3.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doug-martin doug-martin

@dustinsmith1024 dustinsmith1024

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@doug-martin @dustinsmith1024 @cbrittingham