Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change eindirect behave match with indirect from decode #358

Merged
merged 5 commits into from Jun 25, 2022
Merged

change eindirect behave match with indirect from decode #358

merged 5 commits into from Jun 25, 2022

Conversation

kkHAIKE
Copy link
Contributor

@kkHAIKE kkHAIKE commented Jun 16, 2022

fix #357

@arp242
Copy link
Collaborator

arp242 commented Jun 16, 2022

Thanks!

One thing that's missing is a few tests that test the new behaviour.

@kkHAIKE
Copy link
Contributor Author

kkHAIKE commented Jun 17, 2022

add test.
but i found origin TestEncodeTextMarshaler has bug with Sound field. when change Encode obj to '&x', but use my fix is work around....nnn

output:

Name = "Goblok"

[Sound]
  S = "miauw"
Sound2 = "miauw"
Food = "chicken, fish"
Food2 = "chicken, fish"
Complex = "(42.000000+666.000000i)"
Fun = "why would you do this?"

[Labels]
  color = "black"
  type = "cat"

@kkHAIKE
Copy link
Contributor Author

kkHAIKE commented Jun 17, 2022

i found other bug with embed private struct/interface, let me make new commit

@kkHAIKE
Copy link
Contributor Author

kkHAIKE commented Jun 17, 2022

fixed with privete embed struct / nostruct field, behaviour like json.Marshal

@arp242
Copy link
Collaborator

arp242 commented Jun 17, 2022

but i found origin TestEncodeTextMarshaler has bug with Sound field. when change Encode obj to '&x', but use my fix is work around

Yeah, that's expected; that's what I mentioned in the issue as well.

Anyway, seems good at a glance, but I'll go over your PR in detail later.

@arp242 arp242 merged commit f0ccf71 into BurntSushi:master Jun 25, 2022
@arp242
Copy link
Collaborator

arp242 commented Jun 25, 2022

Thank you!

@kkHAIKE
Copy link
Contributor Author

kkHAIKE commented Jun 28, 2022

Can you create a new tag for last commit 😊

@arp242
Copy link
Collaborator

arp242 commented Jun 28, 2022

I want to pick up a few more small things before a new release @kkHAIKE, because then all non-v2 issues are resolved and I can start working on that. In the meanwhile, you can use a new version in your project by using go get github.com/BurntSushi/toml@master (you don't need a tagged release to get this patch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behaviour with the TextMarshaler interface
2 participants