Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test on 32 bit arch #347

Merged
merged 1 commit into from Feb 23, 2022
Merged

Fix test on 32 bit arch #347

merged 1 commit into from Feb 23, 2022

Conversation

zhsj
Copy link
Contributor

@zhsj zhsj commented Feb 22, 2022

It can be verified by running

$ GOARCH=386 go test ./...
# github.com/BurntSushi/toml [github.com/BurntSushi/toml.test]
./decode_test.go:281:45: constant 9007199254740992 overflows int
./decode_test.go:282:46: constant -9007199254740992 overflows int
./decode_test.go:292:16: constant 9007199254740991 overflows int
./decode_test.go:293:28: constant -9007199254740991 overflows int
FAIL    github.com/BurntSushi/toml [build failed]
?       github.com/BurntSushi/toml/cmd/toml-test-decoder        [no test files]
?       github.com/BurntSushi/toml/cmd/toml-test-encoder        [no test files]
?       github.com/BurntSushi/toml/cmd/tomlv    [no test files]
?       github.com/BurntSushi/toml/internal     [no test files]
?       github.com/BurntSushi/toml/internal/tag [no test files]
?       github.com/BurntSushi/toml/internal/toml-test   [no test files]
FAIL

arp242 added a commit that referenced this pull request Feb 23, 2022
So e.g. #347 is caught. Figure I
might as well use ARM instead of i386.
@arp242 arp242 mentioned this pull request Feb 23, 2022
@arp242 arp242 merged commit 573cad4 into BurntSushi:master Feb 23, 2022
arp242 added a commit that referenced this pull request Feb 23, 2022
So e.g. #347 is caught. Figure I
might as well use ARM instead of i386.
arp242 added a commit that referenced this pull request Feb 23, 2022
So e.g. #347 is caught.
@zhsj zhsj deleted the fix-32 branch February 23, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants