Removed write quote in marshal to allow write other types than strings #344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main issue was that in enconde.go Line 215, the marshaled result was wrote with quotes, making imposible to write other values than strings.
Now the implementer of marshal, is responsible to write the quotes if required, as it happens in other marshalers if we compare it to JSON marshal, but it gives more flexibility.
The full issue is explained here: #341
An easy way to verify the issue is change enconde.go Line 215 to its previous state an run the test