Decode S=[] into a non-nil []interface{}. #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores v0.3 behaviour and also makes it
consistent with how the same decodes into something
like struct { S []string }.
Closes BurntSushi#338
|
The struct behaviour I'm referring to is already tested in TestDecodeSlices |
arp242
reviewed
Jan 12, 2022
| @@ -618,6 +618,17 @@ func TestDecodeSlices(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestDecodeInterfaceSlice(t *testing.T) { | |||
| var v map[string]interface{} | |||
| if _, err := Decode(`S = []`, &v); err != nil { | |||
There was a problem hiding this comment.
Could you also test nested arrays and inline tables?
arr = []
nested = [[]]
tbl = {arr = []}
Just to make sure this keeps working in all future updates!
There was a problem hiding this comment.
Actually, looking at this a bit closer the tests should be integrated with TestDecodeSlices, I'll just merge this as-is and fix it up; thanks!
| // Initialize to a non-nil empty slice. This makes it | ||
| // consistent with how S = [] decodes into a non-nil slice | ||
| // inside something like struct { S []string }. | ||
| array = []interface{}{} |
There was a problem hiding this comment.
Could you mention your issue in this comment? Just for future reference.
Also, might as well move this up with the declaration: array = []interface{}{} rather than defining it and then assigning a value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores v0.3 behaviour and also makes it
consistent with how the same decodes into something
like struct { S []string }.
Closes #338