Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency loop in latest tag #312

Closed
niallnsec opened this issue Aug 4, 2021 · 4 comments
Closed

Dependency loop in latest tag #312

niallnsec opened this issue Aug 4, 2021 · 4 comments

Comments

@niallnsec
Copy link

Hello,

It appears that the new v0.4.0 tag has introduced a fatal dependency loop which is prevent any modules which reference this repo from updating. The output from go get -u is as follows:

go get: github.com/BurntSushi/toml@v0.3.1 updating to
        github.com/BurntSushi/toml@v0.4.0 requires
        github.com/BurntSushi/toml-test@v0.1.1-0.20210723065233-facb9eccd4da requires
        github.com/BurntSushi/toml@v0.3.2-0.20210704081116-ccff24ee4463 requires
        github.com/BurntSushi/toml-test@v0.1.1-0.20210704062846-269931e74e3f requires
        github.com/BurntSushi/toml@v0.3.2-0.20210624061728-01bfc69d1057 requires
        github.com/BurntSushi/toml-test@v0.1.1-0.20210624055653-1f6389604dc6 requires
        github.com/BurntSushi/toml@v0.3.2-0.20210621044154-20a94d639b8e
@niallnsec
Copy link
Author

I should also add the problem does persist in the current master as well, even after the updated version of toml-test:

go: github.com/BurntSushi/toml@v0.4.1-0.20210804092126-444cd1471c30 requires
        github.com/BurntSushi/toml-test@v1.0.0 requires
        github.com/BurntSushi/toml@v0.4.0 requires
        github.com/BurntSushi/toml-test@v0.1.1-0.20210723065233-facb9eccd4da requires
        github.com/BurntSushi/toml@v0.3.2-0.20210704081116-ccff24ee4463 requires
        github.com/BurntSushi/toml-test@v0.1.1-0.20210704062846-269931e74e3f requires
        github.com/BurntSushi/toml@v0.3.2-0.20210624061728-01bfc69d1057 requires
        github.com/BurntSushi/toml-test@v0.1.1-0.20210624055653-1f6389604dc6 requires
        github.com/BurntSushi/toml@v0.3.2-0.20210621044154-20a94d639b8e

@arp242
Copy link
Collaborator

arp242 commented Aug 5, 2021

Yeah, this is being discussed at toml-lang/toml-test#74 as well.

I'll look this afternoon; it does work most of the time, but not in some cases. Specifically, GOPROXY=direct seems to break it 🤔

@vissong

This comment has been minimized.

@arp242
Copy link
Collaborator

arp242 commented Aug 5, 2021

Fixed in #313, and tagged v0.4.1 with this fix.

@arp242 arp242 closed this as completed Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants