Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow itemprop in DocumentMeta #2108

Merged
merged 2 commits into from Nov 12, 2022
Merged

feat: allow itemprop in DocumentMeta #2108

merged 2 commits into from Nov 12, 2022

Conversation

ahashem95
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Add itemprop in DocumentMeta type.

Use cases and why

It may be used for schema.org micro-formatting.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@stackblitz
Copy link

stackblitz bot commented Nov 12, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@manucorporat
Copy link
Contributor

Thanks a lot for the PR! sicne this change changes some of the public Api, you need to run:

yarn api.update

@ahashem95
Copy link
Contributor Author

@manucorporat
Thanks for the QWIK reply! Just updated the public API .md file.

@manucorporat manucorporat merged commit 803bcee into QwikDev:main Nov 12, 2022
@manucorporat
Copy link
Contributor

Merged!! thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahashem95 @manucorporat @abdhashem