Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUTORIAL: Lifecycle Hooks - useWatch task #1160

Merged
merged 2 commits into from Nov 20, 2022
Merged

Conversation

jmmon
Copy link
Contributor

@jmmon jmmon commented Aug 28, 2022

What is it?

  • [ x ] Docs / tests

Description

Lifecycle Hooks - useWatch:
Problem now has task for the user to solve

Use cases and why

Previous behavior: problem was same as solution
Expected behavior: problem would have a task for the user to solve

Now, users have a task to solve on this tutorial.

Checklist:

  • [ x ] My code follows the developer guidelines of this project
  • [ x ] I have performed a self-review of my own code
  • [ n/a ] I have made corresponding changes to the documentation
  • [ n/a ] Added new tests to cover the fix / functionality

Problem now has task for the user to solve
@manucorporat
Copy link
Contributor

need npm run fmt to solve the lint issues!

@gitguardian
Copy link

gitguardian bot commented Nov 19, 2022

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Google API Key a6fc9b2 packages/docs/scripts/showcase.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@manucorporat manucorporat merged commit 8812c6e into QwikDev:main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants