TUTORIAL: useResource now has a task #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I expected there to be a task for this tutorial but the given code was the same as the given solution, leaving nothing for users to do on this task. Now, users have two tasks: 1. create the `useResource$()` function (there is an exact answer already provided in the text on the left to make it easy) 2. create the <Resource> component (I left the `onResolved` callback function in a comment, so all they need to do is lay out the component and props like the example in the text on the left)
mhevery
approved these changes
Aug 27, 2022
|
LGTM, please fix lint errors. |
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Google API Key | ade2c3e | packages/docs/scripts/showcase.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
I expected there to be a task for this tutorial but the given code was the same as the given solution, leaving nothing for users to do on this task. Now, users have two tasks:
useResource$()function (there is an exact answer already provided in the text on the left to make it easy)onResolvedcallback function in a comment, so all they need to do is lay out the component and props, like the example in the text on the left)Use cases and why
Checklist: