Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env var AUTOMATION_THREAD_TIMEOUT is ignored #13660

Closed
1 task done
marzzzello opened this issue May 10, 2024 · 2 comments
Closed
1 task done

Env var AUTOMATION_THREAD_TIMEOUT is ignored #13660

marzzzello opened this issue May 10, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@marzzzello
Copy link

Checklist

  • I have searched budibase discussions and github issues to check if my issue already exists

Hosting

  • Self
    • Method: docker compose
    • Budibase Version:
    • App Version: 2.24.2

Describe the bug
I have an automation that runs quite long and I increased the timeouts. For the cron job it works fine but when I click "Run test" in the automation editor it still timeouts.
I think the problem is that the env var AUTOMATION_THREAD_TIMEOUT is ignored because of missing parentheses after ||:

parseIntSafe(process.env.AUTOMATION_THREAD_TIMEOUT) ||
DEFAULTS.AUTOMATION_THREAD_TIMEOUT > QUERY_THREAD_TIMEOUT
? DEFAULTS.AUTOMATION_THREAD_TIMEOUT
: QUERY_THREAD_TIMEOUT,
BB_ADMIN_USER_EMAIL: process.env.BB_ADMIN_USER_EMAIL,

To Reproduce
Steps to reproduce the behavior:

  1. Set AUTOMATION_THREAD_TIMEOUT to 60000 (or noticeably more than 12000)
  2. Create an automation that needs noticeably longer than 12s
  3. Click on Run test
  4. Get timeout error

Expected behavior
No timeout

@marzzzello marzzzello added the bug Something isn't working label May 10, 2024
Copy link

linear bot commented May 10, 2024

@mike12345567
Copy link
Collaborator

This will be fixed in 2.26.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants