Option to scroll by total pixels scrolled or proportionally #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 10, 2014 16:15
|
Should we test this option? Do you test option changes in any other feature? |
|
Don't worry about that for now - I'm looking at better ways to test scrolls anyway so I'll make sure it's tested before I publish this to NPM |
shakyShane
added a commit
that referenced
this pull request
Feb 10, 2014
Option to scroll by total pixels scrolled or proportionally
|
Thanks - great work as always :) |
|
Also, I'll add this to the wiki on the next release |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browser-sync should synchronize scroll by total pixels scrolled too (which was the behavior of this feature before #31). This PR fixes #64.
scrollProportionallyoption was added to browser-sync options. It's default istrue. Wiki/options should be updated after this PR get merged.Simple changes to
browser-sync-client.jswere needed. Just conditionals to use raw or proportional scroll values.