Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error summary: include bulit-in bottom margins #881

Open
dlockhart opened this issue Oct 1, 2020 · 0 comments
Open

Error summary: include bulit-in bottom margins #881

dlockhart opened this issue Oct 1, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@dlockhart
Copy link
Member

In a typical scenario, a form is placed inside a panel or on a page that already has margins configured, like this:

<div style="margin: 20px;">
    <d2l-form>
        <!-- form elements -->
    </d2l-form>
</div>

That looks good when there aren't any errors:

Screen Shot 2020-10-01 at 11 05 47 AM

But as soon as there are errors, the summary is placed at the top and because it has no bottom margins, the top of the form is right against it:

Screen Shot 2020-10-01 at 11 06 29 AM

I think some default bottom margins on the summary would solve this nicely. In the LMS we use 10px as the bottom margin on the summary, but possibly something similar to the space between fields (1.5rem = 30px) would work better. Could use some design input (FYI @geurts).

@dlockhart dlockhart added the enhancement New feature or request label Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant