Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested d2l-dialog can cause outer dialog to close when closed. #1122

Open
dbatiste opened this issue Feb 8, 2021 · 0 comments
Open

Nested d2l-dialog can cause outer dialog to close when closed. #1122

dbatiste opened this issue Feb 8, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@dbatiste
Copy link
Contributor

dbatiste commented Feb 8, 2021

Ref: Activities#1476.

The DialogMixin already provides some support for stopping the propagation of the d2l-dialog-close event so that outer dialogs aren't automatically closed, however internally it supports both native dialog element and our own custom dialog implementation, and this logic was overlooked for the native declarative usage.

This is probably partly due to the fact that nested dialogs are not "advertised" as supported because a) we don't really want to use nested dialogs from a design perspective; and b) when the dialogs components were originally built there were some issues encountered with nested dialogs in either IE11, legacy Edge, or both. In short, hardening nested dialog scenario was deferred until we saw legit need for them.

There is a demo page for it, however it uses the open method supports this use case properly, and so it requires modification to reproduce this bug.

Alternate to the existing slo'n to call stopPropagation on the event, we can consider changing the event the bubbles: false, however that may or may not cause some breakage for the component, and its consumers.

@dbatiste dbatiste added the bug Something isn't working label Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant