Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npmVersion should be specified #53

Closed
justinedelson opened this issue Feb 6, 2019 · 2 comments
Closed

npmVersion should be specified #53

justinedelson opened this issue Feb 6, 2019 · 2 comments

Comments

@justinedelson
Copy link

Due to eirslett/frontend-maven-plugin#560, the frontend-maven-plugin doesn't operate well in cases where node/npm is not installed on the system (and, in fact, you could argue that it doesn't operate well even when those are installed on the system since running npm from npm would result in the system npm being called, not the plugin-managed one).

As such, it would be best if this project (which is great BTW) would specify npmVersion in the ui.apps/pom.xml file.

Of course, it would be better if that bug was fixed, but it has been open for 2 years.

@gaetanmarmasse
Copy link
Contributor

Hi Justin,
Good point! We'll start looking into adding this.
Thanks for the feedback.

@gaetanmarmasse
Copy link
Contributor

Fix added by #54.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants