Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other m4b containers fail to retrieve all the chapters #736

Open
jigzahoy opened this issue Jan 19, 2021 · 1 comment
Open

Other m4b containers fail to retrieve all the chapters #736

jigzahoy opened this issue Jan 19, 2021 · 1 comment
Assignees
Labels
bug Bug, will addressed with high priority

Comments

@jigzahoy
Copy link

Clearly understandable that includeChapters is currently an experimental feature, and thank you for your hard work! It would be an overkill just to put ffmpeg/ffprobe in my application just to get the chapters of an audiobook.

Here are the issues I found and referenced from #731

Bug description

  • .m4b with isom/iso2/mp41 container only returns one chapter but all chapter durations are present.

    • In the parseChapterTrack function, chapterTrack.chunkOffsetTable only contains only one value, and chapterTrack.sampleSizeTable is empty. Which I believe they're dependent to extract the chapter titles.
  • .m4b with M4A/isom/iso2, it doesn't return any chapter lists.

Audio file demonstrating the problem
Audio files were given privately as they were copyrighted material.

@Borewit Borewit added the bug Bug, will addressed with high priority label Jan 19, 2021
@Borewit
Copy link
Owner

Borewit commented Jan 19, 2021

I had a quick look to the decoding of both files you provided. It's complex the chapter encoding, I need to find a bit more time to get my head around this one.

Related PR adding chapter decoding: #325.

@Borewit Borewit self-assigned this Jan 25, 2021
@Borewit Borewit pinned this issue Feb 14, 2021
@Borewit Borewit unpinned this issue Feb 25, 2021
@Borewit Borewit pinned this issue Feb 25, 2021
@Borewit Borewit unpinned this issue Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, will addressed with high priority
Projects
None yet
Development

No branches or pull requests

2 participants