-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for iTunes ID3v2 tag 'GRP1' == 'grouping' #570
Comments
Sounds good. It needs to be added to the text cases I guess, this is slightly different then an empty case. From that point it would be accessible via
Sure
Hmm it's sounds tricky. So we need to change the interpretation of I noticed the Do you have sample files? |
Happy to submit a PR, and I can provide sample files. Possible cases (all mp3, as the issue doesn't seem to exist for m4a and I haven't explored other encodings/containers):
I'm not sure that it's possible to successfully cover all of those cases with internal logic, which is why I had indicated that just having it available on But the possible logic would be: if Beyond that, I don't think it's possible to deterministically conclude, if both |
Why not like this?:
Maybe exposing the |
Can we expect follow up on this issue @rossgrady? |
Hey @Borewit! We recently ran across a need for this, as well. kid3/kid3-cli seems to recognize it:
On a related note, lyrics would be super handy too! |
Did some deeper digging into "Grouping" in music-metadata. I didn't notice it under the |
Feature Request
Due to some bad decisions, the iTunes team a few years ago repurposed
TIT1
forWork Name
and introduced a nonstandard tagGRP1
forgrouping
. (http://blog.jthink.net/2016/12/itunes-add-new-grouping-field-but.html)This only seems to apply to mp3s encoded/edited in iTunes/Music, as their native m4a tag scheme uses
@grp
forgrouping
I need to use
grouping
in a Smart Playlist use-case and I'm trying to validate that the metadata in a file is correct before pushing it to iTunes. I have to be able to handle both mp3s and m4a files.The changes needed to support
GRP1
are trivial -- an emptycase:
statement for it in id3v2/FrameParser, and something in ID3v24TagMapper to map it to something.My understanding is that the common-metadata tag
grouping
isn't multi-value, which is why I assume you haven't added this support already.Any thoughts about how one might go about supporting it? It is unfortunately all too possible to have both
TIT1
andGRP1
set in a single file, so there is definitely the risk of a collision.For my use-case, it would be sufficient to have music-metadata surface
GRP1
and make it available somewhere on the metadata object, even if it wasn't pushed into thecommon
object.The text was updated successfully, but these errors were encountered: