Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken OpenAPI doc links when deployed as serverless #99

Closed
demeringo opened this issue Jun 12, 2022 · 5 comments
Closed

Broken OpenAPI doc links when deployed as serverless #99

demeringo opened this issue Jun 12, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@demeringo
Copy link
Collaborator

demeringo commented Jun 12, 2022

Bug description

There remain a problem with the links in openapi doc that do not include the default stage prefix used when deploying with the serverless framework.

The OpenAPI doc is well served and displayed but the links used to test the API do not work.

Note: this issue would disappear if using a custom domain (like dev.boa.my-domain.com and prod/boa.my-domain.com).

For example:
OpenAPI is pointing to this URL (without the dev prefix):

https://1rq5nf92sb.execute-api.eu-west-1.amazonaws.com/v1/server/all_default_models

while content is served from the same URL (but with the dev prefix):

https://1rq5nf92sb.execute-api.eu-west-1.amazonaws.com/**dev**/v1/server/all_default_models

Expected behavior

Open API spec links should work in sls deployment

JSON OUTPUT

Additional context

Related issues that may be helpfull

@demeringo demeringo added the bug Something isn't working label Jun 12, 2022
@demeringo
Copy link
Collaborator Author

@demeringo
Copy link
Collaborator Author

@demeringo
Copy link
Collaborator Author

Commit 6fe3498 should fix it.

@demeringo demeringo added this to To do in APIs-BOAVIZTA via automation Jun 13, 2022
@demeringo demeringo self-assigned this Jun 13, 2022
@demeringo demeringo moved this from To do to TO REVIEW in APIs-BOAVIZTA Jun 13, 2022
@da-ekchajzer
Copy link
Collaborator

Can I close this issue since 6fe3498 has been merged?

@demeringo
Copy link
Collaborator Author

Yes, thanks, I close it now.

APIs-BOAVIZTA automation moved this from TO REVIEW to Done Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants