New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve hex encode/decoder #9

Closed

MathiasKoch opened this issue Apr 1, 2020 · 1 comment · Fixed by #16

Assignees

Labels

bug 🐛 enhancement 👍

Member

MathiasKoch commented Apr 1, 2020 •

edited

The current hex encoder & decoder is a quickfix, that should probably be replaced with rust-hex once KokaKiwi/rust-hex#42 is merged.

ublox-cellular-rs/src/client.rs

Lines 335 to 338 in 373672c

    
           // TODO: Handle this decoding in-place? 
        
           let data: heapless::Vec<_, consts::U200> = 
        
               hex::decode_hex(&socket_data.data).map_err(|_| Error::BadLength)?; 
        
           Ok(tcp.rx_enqueue_slice(&data))

MathiasKoch added bug 🐛 enhancement 👍 labels

MathiasKoch self-assigned this

Member Author

MathiasKoch commented May 6, 2020

This is currently being addressed in https://github.com/BlackbirdHQ/ublox-cellular-rs/tree/refactor/new-atat

MathiasKoch mentioned this issue

feature/new-atat #16

Merged

MathiasKoch closed this as completed in #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment