Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Version of LiquidFun integration? #56

Open
KTRosenberg opened this issue Jan 17, 2023 · 2 comments
Open

C++ Version of LiquidFun integration? #56

KTRosenberg opened this issue Jan 17, 2023 · 2 comments

Comments

@KTRosenberg
Copy link

KTRosenberg commented Jan 17, 2023

This seems to be the only attempt to re-merge LiquidFun into the latest box2d, but it seems to build a final wasm, rather than generating source files for inclusion in a project. Would you know if there is a way to get updated sources for integration in a C++ project?

@Birch-san
Copy link
Owner

the WebAssembly is built from C++.
my fork of box2d's C++ has the liquidfun source manually-rebased onto it:
google/liquidfun#81 (comment)

@KTRosenberg
Copy link
Author

Ah, thank you for the link. Somehow I missed it.
Is this something I could update with fixes from the main branch? Some things have been tweaked in the past few months.
I might have missed some automatic script you might have used.

By the way, I assume this won’t really be supported in the long run. Version 3 was just announced and it’s going to have a major overall.

I wonder: is there a way to incorporate the essential elements of liquidfun (or some alternative liquid simulation) into the base branch without modifying the original source quite as significantly?

For example: instead of modifying function signatures, use a global context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants