Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment workflow out of date #31

Closed
ahl27 opened this issue May 10, 2022 · 2 comments · Fixed by #32
Closed

Deployment workflow out of date #31

ahl27 opened this issue May 10, 2022 · 2 comments · Fixed by #32

Comments

@ahl27
Copy link

ahl27 commented May 10, 2022

Hi there,

Following the instructions in the package exactly leads to failing GH Action checks at the "Deploy" phase of r-build-and-check. This is presumably due to an error introduced within the past month causing the workflow to be unable to initialize a repository (see Issue #1110, Issue #1083). This has subsequently been fixed in later releases, but the workflow bundled in the template repository doesn't seem to work.

The fixes for this are:

  • update JamesIves/github-pages-deploy-action@releases/v3 -> JamesIves/github-pages-deploy-action@releases/v4 in basic_checks.yaml:68
  • Add an entry in the README to tell users to ensure "Read and Write permissions" are checked under Settings > Actions > General > Workflow permissions
seandavi added a commit that referenced this issue May 10, 2022
Add permissions check re: #31
seandavi added a commit that referenced this issue May 10, 2022
Fixes actions workflow step version per #31
@ahl27
Copy link
Author

ahl27 commented May 10, 2022

Thanks for the quick fix!

@seandavi
Copy link
Collaborator

seandavi commented May 10, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants