Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating all objects without prototypes breaks public API #55

Closed
nerdbeere opened this issue Jan 18, 2019 · 4 comments
Closed

Creating all objects without prototypes breaks public API #55

nerdbeere opened this issue Jan 18, 2019 · 4 comments

Comments

@nerdbeere
Copy link

Hi @BinaryMuse

one could argue that the changes introduced in 7f84702 are changing the public api of your module and following semver should lead to a new major version instead of the patch version you published.

I use nconf in combination with your package which unfortunately relies on Object.hasOwnProperty which no longer works.

@kosmasgiannis
Copy link

See also indexzero/nconf#314

@BinaryMuse
Copy link
Owner

@nerdbeere You're right - sorry about this. I didn't consider it until after it was published to npm, and I sort of waffled on whether or not it would be a breaking change.

I'm thinking of reverting this change, publishing a new 2.x release, and then re-committing the fix in a new 3.x line. Do you have any other ideas?

@nerdbeere
Copy link
Author

@BinaryMuse Sounds like a good strategy to me.

@BinaryMuse
Copy link
Owner

This change is reverted in v2.3.6 and has been reapplied for v3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants