-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test explorer creates a test case each time a keystroke is registered #2530
Comments
Oh, wow. That's really weird. And awful. Is there a way you can create a reproduction project? It needn't be a super minimal repro to begin with. We can try to shrink it together. |
I'll work on it some time today and share the repo link here. Thank you PEZ. |
Hi PEZ: Please find the minimal clojure project I have set up: https://github.com/hjbolide/minimal-clj. What I noticed also during this is: test explorer only updates whenever things are added to the file, new paste, new typed in characters, deletion doesn't seem to update the test explorer at all. Here's another couple of screenshots: Thank you for your time. |
Hi, thanks for the project. To make it a repro project, please add instructions to it of how to reproduce the problem. I'm not a test explorer user so it needs to be a bit detailed. |
Oh I'm sorry, let me add the detailed steps: Steps to reproduce
|
I can reproduce this easily with any project. It seems we do not implement clojure-lsp testTree as we should. @ericdallo where can I read about how to implement it properly? The problem here is that we get notifications for the new deftest symbol, but we don't get anything about the old one, so I am guessing we should listen on something more than just this: client.client.onNotification('clojure/textDocument/testTree', (tree: defs.TestTreeParams) => {
params.testTreeHandler(tree);
}); |
Environment
VsCodium: v1.88.1
Calva: 2.0.446
Issue
Test explorer creates a test case each time a keystroke is registered, ended up having a lot of test cases with cut up names. Not sure if it's related, the gutter icons are all over the place.
Reloading the namespace or whole repl doesn't help.
Screenshots
Has anyone run into this issue before and have a workaround?
Thanks.
The text was updated successfully, but these errors were encountered: