Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPL window loses its scroll position when changing file in a split #2440

Open
gtbono opened this issue Mar 18, 2024 · 1 comment
Open

REPL window loses its scroll position when changing file in a split #2440

gtbono opened this issue Mar 18, 2024 · 1 comment

Comments

@gtbono
Copy link
Contributor

gtbono commented Mar 18, 2024

I am having a bug in Calva with my REPL window.

Steps to reproduce:
Open the REPL Window in a right split.
If the REPL window have enough content
If I open the REPL window in a splited window and the REPL window have sufficient content enough so that the scroll is in the middle of the file (could scroll both up and down)
Now, on the other side of the split that is not the REPL, do some action for changing the file, for example a Cmd+P and select another file
See the REPL window lose its scroll position

I believe it should not lose its scroll position as every other file that is not the REPL window does not lose the position.

If my steps to reproduce are not clear I can explain more, or try to grab screenshots and record a video.

I'm using the latest Calva (v2.0.424) and VS Code (1.87.2) on a Mac with a clean VS Code install with no plugins except Calva and no custom setting

@PEZ
Copy link
Collaborator

PEZ commented Mar 27, 2024

I think I know what's happening, and it is by design. When you change to a Clojure file in VS Code, the active namespace of the REPL Window updates, this causes it to print a new prompt.

What we are lacking in the REPL Window is a scroll lock. I've had one implemented on my machine at some time, but failed in making it reliable enough so I never committed that code. Ideally, imo, it would work like a VS Code terminal works, that it locks scroll whenever you manually scroll up, and unlocks when the window is fully scrolled to the bottom. Sounds simple, and I don't quite remember why I had problem with it. Might have been holding the API:s wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants