Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when slurping forward before commented s-expressions #2387

Open
blnote opened this issue Jan 23, 2024 · 3 comments
Open

error when slurping forward before commented s-expressions #2387

blnote opened this issue Jan 23, 2024 · 3 comments
Labels
paredit Paredit and structural editing structural editor Token Cursor, Lexer, et al

Comments

@blnote
Copy link

blnote commented Jan 23, 2024

Using the slurp sexp forward command at
(|) #_(dosomething)

results in

( #_)(dosomething)

and the error:

:uneval node expects 1 value. [at line 1, column 6]

also: drag expression forward in the above scenario produces
#_ ()(dosometing)
destroying the commented expression. no error is printed in this case.

Calva version used: v2.0.409
clojure-lsp version used: 2023.12.29-12.09.27
clj-kondo version used: 2023.12.15

@PEZ PEZ added paredit Paredit and structural editing structural editor Token Cursor, Lexer, et al labels Feb 8, 2024
@PEZ
Copy link
Collaborator

PEZ commented Feb 8, 2024

Hi! Thanks for reporting!

The issue with how to treat the ignore marker is a bit unsolved in Calva. I agree the behaviour is incorrect, but will have to investigate if it can be easily solved without causing funny behaviour elsewhere.

@blnote
Copy link
Author

blnote commented Feb 9, 2024

Hey, thanks for your response!
Just wanted to note that slurping ignored forms works with clojure-lsp (using paredit functionality from rewrite-clj i think). however dragging using lsp also has a problem with ignored forms. anyways, certainly not high priority, thanks a lot for your work.

@PEZ
Copy link
Collaborator

PEZ commented Feb 11, 2024

I see that there is a rather old PR concerning ignore markers and dragging:

I don't recall why we never merged it. Maybe we just forgot? Anyway, I'll have a look and see if it enlightens/reminds me a bit about the nature of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paredit Paredit and structural editing structural editor Token Cursor, Lexer, et al
Projects
None yet
Development

No branches or pull requests

2 participants