Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve editor support for virtual environments #488

Merged
merged 8 commits into from Nov 4, 2020

Conversation

RobinDaugherty
Copy link
Member

@RobinDaugherty RobinDaugherty commented Oct 31, 2020

  • Add support for BETTER_ERRORS_EDITOR env var, which is used instead of EDITOR if present.
  • Add %{file_unencoded} replacement to editor formatting string, so when a URL needs to be unencoded, it doesn't require a Proc.
  • Add support for BETTER_ERRORS_EDITOR_URL env var, which allows the editor to be fully customized without modifying code.
  • Add support for BETTER_ERRORS_VIRTUAL_PATH and BETTER_ERRORS_HOST_PATH which, used together, cause the virtual path to be stripped from file paths, and the host path to be prefixed.

This refactors editor detection out of the BetterErrors class into a new Editor class, while preserving the call pattern on BetterErrors.editor=.

@RobinDaugherty RobinDaugherty added this to the v2.10 milestone Nov 4, 2020
Adding support for BETTER_ERRORS_EDITOR env var.
@coveralls
Copy link

coveralls commented Nov 4, 2020

Pull Request Test Coverage Report for Build 346260966

  • 55 of 55 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 96.838%

Totals Coverage Status
Change from base Build 346133107: 0.5%
Covered Lines: 490
Relevant Lines: 506

💛 - Coveralls

@RobinDaugherty RobinDaugherty merged commit 66f2949 into master Nov 4, 2020
@RobinDaugherty RobinDaugherty deleted the feature/editor-support-docker branch November 4, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants