Fix various specs that were passing incorrectly #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were finding it in the exception backtrace that was being dumped to the HTML.
and expose another should-be-failing spec
|
Great, I was completely puzzled by the obscure string concatenation in the specs. |
|
Yeah, this was surprising. The deeper I dug, the more broken specs I found. Really glad we found this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many specs for the
ErrorPagewere only looking at whether certain strings appeared in the HTML that was generated. But for different reasons, the string being matched could be included in the generated HTML for other reasons.For example, if an exception was raised inside of the spec example, the resulting page would be rendered from that exception instead, and it would include lines of code from the exception.
There was some attempt to fix this by breaking up strings in the specs and concatenating them at runtime so that the entire string wasn't in the spec file.
The fix is to use HTML matching and verify that the page contains the correct tags with the content, not just the text.
This failure was exposed by CI failure in #449.