Skip to content

Update CI Ruby to fix Travis CI failures #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

felixbuenemann
Copy link
Contributor

Update Rubies to latest minor version and exclude Rails 4.2 specs on Ruby 2.3, since the default bundler 2.1.2 gem breaks the downgrade.

Note that I tried to fix this first by using export BUNDLER_VERSION=1.3, which works fine locally to prefer Bundler 1.x, even if 2.x is installed, but for some reason that didn't work on Travis CI either.

If we really wanted to we could install bundler 1.17.3 and oveeride the install step to run bundle _1.17.3_ install …, but since Rails 4.2 is EOL imho the easiest thing is to just run the 4.2 specs on Ruby 2.2.10.

Update Rubies to latest minor version and exclude Rails 4.2 specs on
Ruby 2.3, since the default bundler 2.1.2 gem breaks the downgrade.
@kingdonb
Copy link

Thanks for figuring this out @felixbuenemann !

Do you know if there are plans to make a new release soon? I noticed you have several PRs open. Wondered if you had other issues that should be resolved prior to a release.

(I was hoping to figure out #451 but it turns out it's not as bad as I thought...)

I cannot use better_errors without pointing my Gemfile at the master branch at present

@felixbuenemann
Copy link
Contributor Author

Hey @kingdonb, the internet is a small place :-)

I've got no more outstanding fixes. I'm not a maintainer, so no idea about release plans.

@RobinDaugherty RobinDaugherty changed the title Fix Travis CI Build Problems Update CI Ruby to fix Travis CI failures problems Feb 25, 2020
@RobinDaugherty
Copy link
Member

Thanks for the fix @felixbuenemann!

@RobinDaugherty RobinDaugherty merged commit f036061 into BetterErrors:master Feb 25, 2020
@RobinDaugherty RobinDaugherty changed the title Update CI Ruby to fix Travis CI failures problems Update CI Ruby to fix Travis CI failures Feb 25, 2020
@felixbuenemann felixbuenemann deleted the fix-rails-4.2-ci branch February 26, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants