Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable inspection specs #403

Conversation

RobinDaugherty
Copy link
Member

  • Rename empty_binding variable to exception_binding, since it's obviously not empty.
  • Fix the specs covering variable inspection. These specs were looking for the names of variables but actually, since RSpec includes in the scope of the example a copy of the example itself, it was just finding the source code of the example dumped in the HTML. I changed it to match the HTML itself rather than just the variable name, and splitting the HTML string keeps it from matching against the source of the example.
  • Now that the variable inspection specs are working correctly, they would fail if run without binding_of caller. So I moved them into the conditional block so that they only run with boc.

@RobinDaugherty RobinDaugherty merged commit c0044fc into BetterErrors:master Aug 25, 2017
@RobinDaugherty RobinDaugherty deleted the fix/variable-inspection-specs branch August 25, 2017 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant