Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add expiring application props to create and update models #250

Merged
merged 2 commits into from Nov 23, 2022
Merged

fix: add expiring application props to create and update models #250

merged 2 commits into from Nov 23, 2022

Conversation

lcschy
Copy link
Contributor

@lcschy lcschy commented Nov 23, 2022

Description

  • Adds expiresAt and canCreateExpiringApplications to CreateApplication model
  • Adds canCreateExpiringApplications to UpdateApplication model

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@lcschy lcschy requested a review from a team as a code owner November 23, 2022 12:24
@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 96.3% ( 442 / 459 )
Methods: 94.5% ( 103 / 109 )

@lcschy lcschy merged commit 237028d into master Nov 23, 2022
@lcschy lcschy deleted the eng-3755-add-to-create-model branch November 23, 2022 12:35
bt-platform-eng pushed a commit that referenced this pull request Nov 23, 2022
@semantic-release-bot
chore(release): 1.56.1 [skip ci]
e8f2527 
## [1.56.1](v1.56.0...v1.56.1) (2022-11-23)

### Bug Fixes

* add expiring application props to create and update models ([#250](#250)) ([237028d](237028d))
@bt-platform-eng
Copy link

🎉 This PR is included in version 1.56.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djejaquino djejaquino djejaquino approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lcschy @bt-platform-eng @djejaquino