Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add setValue method to elements, other qol improvements #248

Merged
merged 2 commits into from Nov 16, 2022
Merged

feat: add setValue method to elements, other qol improvements #248

merged 2 commits into from Nov 16, 2022

Conversation

lcschy
Copy link
Contributor

@lcschy lcschy commented Nov 16, 2022 •
edited

Description

  • Adds setValuemethods to all elements
  • Set type for token data as any on retrieve
    • without this you couldn't do token.data.<someprop> w/o casting to any
  • Set apiKey type as string | undefined to avoid having to cast environment variables
  • Change value of expiration/month year to number where applicable to match API
  • Allow string to be passed as a static value to CardExpirationDateElement

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@lcschy lcschy requested a review from a team as a code owner November 16, 2022 19:09
koalaty-code
koalaty-code previously approved these changes Nov 16, 2022
View reviewed changes
djejaquino
djejaquino reviewed Nov 16, 2022
View reviewed changes
src/elements/services/tokens.ts Outdated Show resolved Hide resolved
src/tokens/BasisTheoryTokens.ts Outdated Show resolved Hide resolved
src/elements/services/tokens.ts Show resolved Hide resolved
src/types/elements/elements.ts Show resolved Hide resolved
src/types/elements/services/tokens.ts Outdated Show resolved Hide resolved
src/types/sdk/services/tokens.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 96.3% ( 442 / 459 )
Methods: 94.5% ( 103 / 109 )

@lcschy lcschy merged commit cac105a into master Nov 16, 2022
@lcschy lcschy deleted the eng-3755-set-value-and-qol branch November 16, 2022 21:14
bt-platform-eng pushed a commit that referenced this pull request Nov 16, 2022
@semantic-release-bot
chore(release): 1.55.0 [skip ci]
cd3c407 
# [1.55.0](v1.54.0...v1.55.0) (2022-11-16)

### Features

* add setValue method to elements, other qol improvements ([#248](#248)) ([cac105a](cac105a))
@bt-platform-eng
Copy link

🎉 This PR is included in version 1.55.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djejaquino djejaquino djejaquino left review comments

@koalaty-code koalaty-code koalaty-code approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lcschy @bt-platform-eng @djejaquino @koalaty-code