Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for expiring applications #247

Merged
merged 10 commits into from Nov 17, 2022
Merged

feat: add support for expiring applications #247

merged 10 commits into from Nov 17, 2022

Conversation

kevinperaza
Copy link
Contributor

Description

  • Add expiresAt and canCreateExpiringApplications to Application

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@kevinperaza kevinperaza force-pushed the eng-3755-add-expiring-apps-fields branch 2 times, most recently from 29f014a to 0f6c5b0 Compare November 14, 2022 16:06
@kevinperaza kevinperaza marked this pull request as ready for review November 14, 2022 16:13
@kevinperaza kevinperaza requested a review from a team as a code owner November 14, 2022 16:13
amkera
amkera previously approved these changes Nov 14, 2022
View reviewed changes
lcschy
lcschy requested changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@lcschy lcschy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Application name is only required for non expiring. We should reflect that.
As it stands it would be required for expiring

@kevinperaza kevinperaza force-pushed the eng-3755-add-expiring-apps-fields branch from 16a3d92 to 6d5fe29 Compare November 15, 2022 22:34
@github-actions
Copy link

Coverage Report

Totals Coverage
Statements: 96.3% ( 442 / 459 )
Methods: 94.5% ( 103 / 109 )

@kevinperaza kevinperaza merged commit 1cf7f16 into master Nov 17, 2022
@kevinperaza kevinperaza deleted the eng-3755-add-expiring-apps-fields branch November 17, 2022 17:35
bt-platform-eng pushed a commit that referenced this pull request Nov 17, 2022
@semantic-release-bot
chore(release): 1.56.0 [skip ci]
9cecae1 
# [1.56.0](v1.55.0...v1.56.0) (2022-11-17)

### Features

* add support for expiring applications ([#247](#247)) ([1cf7f16](1cf7f16))
@bt-platform-eng
Copy link

🎉 This PR is included in version 1.56.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djejaquino djejaquino djejaquino left review comments

@dhudec dhudec dhudec approved these changes

@lcschy lcschy lcschy approved these changes

@jleon15 jleon15 Awaiting requested review from jleon15

@amkera amkera Awaiting requested review from amkera

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kevinperaza @bt-platform-eng @dhudec @djejaquino @lcschy @jleon15 @amkera