Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageStreamCompleter._checkDisposed #785

Closed
PawlikMichal25 opened this issue Oct 4, 2022 · 14 comments
Closed

ImageStreamCompleter._checkDisposed #785

PawlikMichal25 opened this issue Oct 4, 2022 · 14 comments

Comments

@PawlikMichal25
Copy link

PawlikMichal25 commented Oct 4, 2022

I just wanted to mirror here this issue: flutter/flutter#110953 because a couple of people pointed out that it's caused by cached_network_image library flutter/flutter#110953 (comment)

I'm personally using the latest Flutter and cached_network_image versions and can confirm this issue is still happening, though I don't have repro steps

@definitelyme
Copy link

Same issue here @Baseflow. Crashes mainly in Release

@atrope
Copy link

atrope commented Oct 7, 2022

Based on
flutter/flutter#77576
and
flutter/flutter#94902

I've created this:
#777

i am publishing a new version to my users and will check if this fixes the issue.

@atrope
Copy link

atrope commented Oct 7, 2022

This commit to be specific: e812bb8

@VincentDR
Copy link

Same issue on iOS/Android with our production app.
Not able to reproduce it and only about 2/3 of our users are impacted.

@micohalvarez-dart
Copy link

Any updates on the fix for this?

@serg3vr
Copy link

serg3vr commented Oct 14, 2022

I'm running the same issue, not able to reproduce it and it seems only happens on release.
I would like to know if anyone was able to solve it on their own and how they did it?
ty

@atrope
Copy link

atrope commented Oct 14, 2022

I released my app with this fix #777
it is Phased release and for now without errors

@EArminjon
Copy link

I released my app with this fix #777 it is Phased release and for now without errors

Still no error ? Do you have changed something in addition in your code or just taking this forked version and that's all ?

@atrope
Copy link

atrope commented Oct 18, 2022

Hi, I am still checking. The _checkDisposed is completely gone. We have a new one _AsyncStarStreamController.close that i am checking

@davidmartos96
Copy link
Contributor

If someone is able to reproduce the issue it would be nice if he can give this PR branch a try #792
I believe it could solve the case of using the ImageStream once it has been disposed

@renefloor
Copy link
Collaborator

@davidmartos96 thanks for the PR. Would indeed be nice if somebody can verify it.

@ScottMacDougall
Copy link

@renefloor I'm seeing thousands of events logged for this issue in my crashlytics reports, and a new version of the app pointing to the #792 branch appears to have fixed it for a subset of users I pushed the update to.

Would love to see this get published.

@silverhairs
Copy link

Any update on this issue? It seems like #792 works

@renefloor
Copy link
Collaborator

Released as cached_network_image: ^3.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests