Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use loadbuffer and deprecate load #773

Merged
merged 5 commits into from Aug 31, 2022
Merged

use loadbuffer and deprecate load #773

merged 5 commits into from Aug 31, 2022

Conversation

renefloor
Copy link
Collaborator

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bugfix for #772

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

No, only in the platform interface

🐛 Recommendations for testing

📝 Links to relevant issues/docs

#772

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Base: 95.67% // Head: 82.14% // Decreases project coverage by -13.53% ⚠️

Coverage data is based on head (f611c96) compared to base (607a2eb).
Patch coverage: 74.28% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #773       +/-   ##
============================================
- Coverage    95.67%   82.14%   -13.54%     
============================================
  Files            4        5        +1     
  Lines          162      196       +34     
============================================
+ Hits           155      161        +6     
- Misses           7       35       +28     
Impacted Files Coverage Δ
...e/lib/cached_network_image_platform_interface.dart 50.00% <33.33%> (ø)
...rk_image/lib/src/image_provider/_image_loader.dart 88.00% <75.00%> (-6.74%) ⬇️
.../image_provider/cached_network_image_provider.dart 56.36% <79.16%> (-43.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@renefloor renefloor marked this pull request as ready for review August 31, 2022 07:57
@renefloor renefloor merged commit bdbfe33 into develop Aug 31, 2022
@renefloor renefloor deleted the bugfix/use-loadbuffer branch August 31, 2022 08:18
@renefloor renefloor mentioned this pull request Aug 31, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant