Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Upgrade Select & SearchBox to use react-popper #69

Closed
a-type opened this issue Feb 22, 2018 · 3 comments
Closed

Upgrade Select & SearchBox to use react-popper #69

a-type opened this issue Feb 22, 2018 · 3 comments

Comments

@a-type
Copy link
Contributor

a-type commented Feb 22, 2018 •
edited

https://github.com/littlebits/react-popover

React-Popover uses portals so it overcomes a lot of the problems with absolute-positioned pop-out sections. A similar approach could help us.
@a-type a-type changed the title Upgrade Select / SearchBox / Callout to use react-popover Upgrade Select / SearchBox / Callout to use portals Mar 12, 2018
@a-type
Copy link
Contributor Author

a-type commented Mar 12, 2018

JedWatson/react-select#2398

Tracking portal usage in react-select.

@a-type
Copy link
Contributor Author

a-type commented Mar 21, 2018

Update on this: I think a better approach might be to switch to a behavior-driven library like Downshift for apps and provide only visual components from this library.

@zacklitzsinger zacklitzsinger changed the title Upgrade Select / SearchBox / Callout to use portals Upgrade Select & SearchBox to use react-popper Oct 23, 2018
@zacklitzsinger
Copy link
Contributor

react-popper has been working very well, so we should consider adopting it for Select & SearchBox.

@a-type a-type closed this as completed Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-type @zacklitzsinger