Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create classes for 'label' and 'milestone' objects? Or not? #199

Open
dongskyler opened this issue Jun 18, 2021 · 0 comments
Open

Create classes for 'label' and 'milestone' objects? Or not? #199

dongskyler opened this issue Jun 18, 2021 · 0 comments

Comments

@dongskyler
Copy link
Member

dongskyler commented Jun 18, 2021

Both 'label' and 'milestone' classes should be extended from a common class.

Use simple JSON to store data (labels and milestones)? Or create classes for them?

Perhaps, just stick with JSON. Creating classes add a lot of complexities. Besides, those instances of aforementioned classes won't have any methods anyway, as this API is designed with a functional programming spirit. All (or almost all) functions in this repo are pure (without side effects). Let's keep those functions pure.

@dongskyler dongskyler changed the title Create classes for 'label' and 'milestone' objects Create classes for 'label' and 'milestone' objects? Jun 18, 2021
@dongskyler dongskyler changed the title Create classes for 'label' and 'milestone' objects? Create classes for 'label' and 'milestone' objects? Or not? Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant