Allow Dynamic Texture update method to consider the invertY argument. #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghgary
reviewed
Jan 3, 2023
| { | ||
| bgfx::Encoder* encoder = m_update.GetUpdateToken().GetEncoder(); | ||
| GetBoundFrameBuffer(*encoder).Blit(*encoder, textureDestination->Handle(), 0, 0, textureSource->Handle()); | ||
|
|
||
| // Flip texture in memory (maybe there is a way for bgfx to allow flipping to happen on the GPU?) |
There was a problem hiding this comment.
Going to CPU seems like it's unnecessary. At worst case, we should be able to flip using a shader?
|
Closing for now. We can reopen once we are ready to work on the issue again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When calling DynamicTexture.update with values given to the invertY argument nothing happens in Babylon Native. The invertY arguments get completely ignored by the NativeEngine.
See #1186
Implementation
I'm adding a code path where the CPU flips the texture in the Y axis. Maybe there is a better way to do this completely on the GPU but this implementation should be good enough for users to have the expected behavior while we improve it with a more performant version.
Fixes #1186