Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Texture update does not consider invertY argument values #1186

Open
SergioRZMasson opened this issue Dec 27, 2022 · 1 comment
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@SergioRZMasson
Copy link
Contributor

Overview

When calling DynamicTexture.update with values given to the invertY argument nothing happens in Babylon Native. The invertY arguments get completely ignored by the NativeEngine.

From forum issue: https://forum.babylonjs.com/t/react-native-dynamic-texture-update-inverty-parameter-is-not-working-as-expected/36916

Describe the bug
When calling DynamicTexture.update we always get the same results no matter if we give true or false to the invertY argument.

To Reproduce
The following Playground does not render properly in Babylon Native: https://playground.babylonjs.com/#FU0ES5#32

Expected behavior
Texture should be flipped on the Y axis when invertY is set to true.

@SergioRZMasson SergioRZMasson added the bug Something isn't working label Dec 27, 2022
@thomlucc thomlucc added this to the 6.0 milestone Jan 3, 2023
@thomlucc thomlucc modified the milestones: 6.0, 7.0 Mar 20, 2023
@SergioRZMasson SergioRZMasson removed the bug Something isn't working label Sep 19, 2023
@SergioRZMasson
Copy link
Contributor Author

The API works for the default case (when invertY is not specified) so instead of considering this a bug it will be considered a missing feature. Adding Y flipping in bgfx has proven to be very time consuming.

@bghgary bghgary added the enhancement New feature or request label Sep 20, 2023
@bghgary bghgary modified the milestones: 7.0, Future Oct 12, 2023
@thomlucc thomlucc modified the milestones: Future, 8.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants