Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle readTextureAsync cancellation in Native Capture #1131

Open
Alex-MSFT opened this issue Sep 7, 2022 · 0 comments
Open

Properly handle readTextureAsync cancellation in Native Capture #1131

Alex-MSFT opened this issue Sep 7, 2022 · 0 comments
Assignees
Milestone

Comments

@Alex-MSFT
Copy link
Contributor

Alex-MSFT commented Sep 7, 2022

In NativeCapture, we currently do not handle the possibility that readTextureAsync can fail. It is possible that if NativeCapture is running at the end of the engine lifetime that we will not be able to hand back results to NativeCapture, and improperly handle the return value of the task.

We should add some level of exception handling or pre-emptively end the NativeCapture session and drain all remaining readTextures requests during engine shutdown.

See the changes in #1132 for more info.

@Alex-MSFT Alex-MSFT changed the title Properly handle readPixel cancellation in Native Capture Properly handle readTextureAsync cancellation in Native Capture Sep 7, 2022
@thomlucc thomlucc added the 6.0 label Sep 23, 2022
@thomlucc thomlucc modified the milestones: Future, 6.0 Sep 23, 2022
@thomlucc thomlucc removed the 6.0 label Sep 23, 2022
@bghgary bghgary self-assigned this Oct 13, 2022
@thomlucc thomlucc modified the milestones: 6.0, 7.0 Mar 14, 2023
@thomlucc thomlucc modified the milestones: 7.0, 8.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants