Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Engine States in Babylon Native #1106

Open
sebavan opened this issue Jul 20, 2022 · 1 comment
Open

Handle Engine States in Babylon Native #1106

sebavan opened this issue Jul 20, 2022 · 1 comment
Milestone

Comments

@sebavan
Copy link
Member

sebavan commented Jul 20, 2022

Currently, NativeEngine.js does not support changing and relying on states through the available state properties:

   /**
     * Gets the depth culling state manager
     */
    public get depthCullingState(): DepthCullingState {
        return this._depthCullingState;
    }

    /**
     * Gets the alpha state manager
     */
    public get alphaState(): AlphaState {
        return this._alphaState;
    }

    /**
     * Gets the stencil state manager
     */
    public get stencilState(): StencilState {
        return this._stencilState;
    }

    /**
     * Gets the stencil state composer
     */
    public get stencilStateComposer(): StencilStateComposer {
        return this._stencilStateComposer;
    }

Those are only working in WebGL and WebGPU. In Native state changes needs to flow through the old APIs dedicated functions like:
setState, setDepthBuffer and similar...

It is the source of both potential bugs (even in our current version) and forces ThinEngine to be bigger than required.

@sebavan sebavan added bug Something isn't working rendering labels Jul 20, 2022
@bghgary bghgary removed the bug Something isn't working label Jul 21, 2022
@bghgary bghgary self-assigned this Jul 21, 2022
@thomlucc thomlucc added the 6.0 label Sep 23, 2022
@thomlucc thomlucc modified the milestones: Future, 6.0 Sep 23, 2022
@thomlucc thomlucc removed the 6.0 label Sep 23, 2022
@bghgary
Copy link
Contributor

bghgary commented Oct 13, 2022

Related: #778

@bghgary bghgary modified the milestones: 6.0, Future Jan 26, 2023
@bghgary bghgary modified the milestones: Future, 7.0 May 11, 2023
@bghgary bghgary removed their assignment May 11, 2023
@thomlucc thomlucc modified the milestones: 7.0, 8.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants