{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":189081889,"defaultBranch":"master","name":"BabylonNative","ownerLogin":"BabylonJS","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2019-05-28T18:27:37.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4855800?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717167955.0","currentOid":""},"activityList":{"items":[{"before":"59798a738d5c785d9e3eff0863854034e075f29f","after":"efb8fb207d449e3245dd101519a9516dec73ddc4","ref":"refs/heads/master","pushedAt":"2024-05-31T17:23:50.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"},"commit":{"message":"Bump JsRuntimeHost to pick up V8 x86 fix (#1387)","shortMessageHtmlLink":"Bump JsRuntimeHost to pick up V8 x86 fix (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328257198\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1387\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1387/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1387\">#1387</a>)"}},{"before":"1271d0e7525f97254be2caff534a8c9cdacadb47","after":"9555ae234c96c71c0f935692b966f61042227313","ref":"refs/heads/xrFrameLifeCycle","pushedAt":"2024-05-31T15:48:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"CedricGuillemet","name":"Cedric Guillemet","path":"/CedricGuillemet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1312968?s=80&v=4"},"commit":{"message":"assignment operator","shortMessageHtmlLink":"assignment operator"}},{"before":"3ad702b6294595d2140bbdcc55c4ae0f3586a109","after":"1271d0e7525f97254be2caff534a8c9cdacadb47","ref":"refs/heads/xrFrameLifeCycle","pushedAt":"2024-05-31T15:31:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"CedricGuillemet","name":"Cedric Guillemet","path":"/CedricGuillemet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1312968?s=80&v=4"},"commit":{"message":"WIP prototype","shortMessageHtmlLink":"WIP prototype"}},{"before":null,"after":"3ad702b6294595d2140bbdcc55c4ae0f3586a109","ref":"refs/heads/xrFrameLifeCycle","pushedAt":"2024-05-31T15:05:55.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"CedricGuillemet","name":"Cedric Guillemet","path":"/CedricGuillemet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1312968?s=80&v=4"},"commit":{"message":"Fix XR Frame alloc","shortMessageHtmlLink":"Fix XR Frame alloc"}},{"before":"4cf5677903bac3be7a4b18547cc2caa5c23bac67","after":"59798a738d5c785d9e3eff0863854034e075f29f","ref":"refs/heads/master","pushedAt":"2024-05-22T22:23:13.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"},"commit":{"message":"Support non-normalized, non-float vertex buffers and unaligned vertex buffers (#1382)\n\nThis is a replacement for #1376. The original thinking was that we will\r\npromote the non-float attributes to float which was a complex and poor\r\nperformance solution. The better solution is to change the shader to\r\ntake non-float attributes. Fortunately, this shader processing is\r\nalready happening for WebGPU on the JS side. @Popov72 [factored out the\r\nshader processor](https://github.com/BabylonJS/Babylon.js/pull/15107) on\r\nthe JS side for WebGPU to also work with Babylon Native, which also\r\nincludes code that aligns the buffers to 4-byte boundaries. This native\r\nPR ties everything together and removes all the promote to float logic\r\nwe had earlier to try to handle non-float attributes.\r\n\r\nThis change includes updating Babylon.js to 7.7.2. Using an older\r\nversion will result in a `console.error ` if non-normalized, non-float\r\nvertex buffers are used.","shortMessageHtmlLink":"Support non-normalized, non-float vertex buffers and unaligned vertex…"}},{"before":"737bc8e6659016caa99ae051103674494d68bd73","after":"4cf5677903bac3be7a4b18547cc2caa5c23bac67","ref":"refs/heads/master","pushedAt":"2024-05-17T20:50:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"},"commit":{"message":"Update to Babylon.js 7.6.2 (#1373)\n\nUpdating to Babylon.js version 7.0.0 reveals a whole slew of issues when\r\nrunning the validation tests because\r\n[#14868](https://github.com/BabylonJS/Babylon.js/pull/14868) broke the\r\nrender loop stopping behavior when running in native. Native does not\r\nimplement a way to cancel a requested animation frame. This missing\r\ncanceling functionality should be added to native someday, but, in the\r\nmeantime, [#15086](https://github.com/BabylonJS/Babylon.js/pull/15086)\r\nwill make it behave like it did before.\r\n\r\nThese changes fix potential issues in the code regardless of what\r\nhappened on the JS side.\r\n\r\n- Update to latest JsRuntimeHost with lots of fixes.\r\n- Call SetRenderResetCallback with null to clear the callback that can\r\ncause a crash on shutdown.\r\n- Update a few validation tests to not use render count.\r\n- Update scripts to use `const`/`let` instead of `var`.\r\n- Update validation script to handle some errors better and clean up\r\ndead code.\r\n- Add unhandled exception handler to Playground app so that validation\r\ntest will report correct errors and exit correctly.\r\n- Change core graphics device implemenation to update bgfx state right\r\nbefore requesting screenshots. This will ensure the screenshot is the\r\nright size if the resolution has changed.\r\n- Fix TestUtils:WritePNG to return an error when the byte length is an\r\nunexpected size instead of silently failing.\r\n- Change TestUtils::SetTitle to update the HWND title on a background\r\nthread to avoid dead lock with the main thread.\r\n- Update dynamic texture clip test to newest version that will fail if\r\nthe feature is not working.","shortMessageHtmlLink":"Update to Babylon.js 7.6.2 (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2213701650\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1373\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1373/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1373\">#1373</a>)"}},{"before":"6c7b7cb62c16fa6e8d8c26c3db26f1454ce24b09","after":"737bc8e6659016caa99ae051103674494d68bd73","ref":"refs/heads/master","pushedAt":"2024-05-17T07:27:35.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"CedricGuillemet","name":"Cedric Guillemet","path":"/CedricGuillemet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1312968?s=80&v=4"},"commit":{"message":"fix xrView visibility iOS (#1380)\n\nFix bug introduced with\r\nhttps://github.com/BabylonJS/BabylonNative/pull/1368\r\nxrView.isHidden was not the intended value.\r\nI've kept the syntax proposed by @okwasniewski\r\nidk if it's the 'correct' and standard way to do it.\r\ncc @Allan121\r\n\r\nfixes #1379","shortMessageHtmlLink":"fix xrView visibility iOS (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2300655032\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1380\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1380/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1380\">#1380</a>)"}},{"before":"033c7af671ec1c1a9e09c95a1c2a33758a7615f7","after":"6c7b7cb62c16fa6e8d8c26c3db26f1454ce24b09","ref":"refs/heads/master","pushedAt":"2024-05-13T20:42:50.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"},"commit":{"message":"Fix ownership of color texture when creating a frame buffer (#1378)\n\nThe changes in https://github.com/BabylonJS/Babylon.js/pull/15052\r\nexposes a problem in native where the output texture of the BRDF post\r\nprocess will be destroyed causing a crash in bgfx.\r\n\r\nIn the previous code, the `NativeEngine::CreateFrameBuffer` took\r\nownership of the color texture passed in as an argument. This is wrong\r\nbecause the texture might still be needed after the frame buffer dies.\r\nSpecifically, [the BRDF post process that expands the RGBD env\r\ntexture](https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/Misc/rgbdTextureTools.ts#L98)\r\nis where it fails.\r\n\r\nThe new code will not take ownership of the color texture but will still\r\ndelete the generated depth/stencil texture in the finalizer if\r\nnecessary. The calling code will destroy the color texture when\r\nappropriate.","shortMessageHtmlLink":"Fix ownership of color texture when creating a frame buffer (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2290436137\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1378\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1378/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1378\">#1378</a>)"}},{"before":"909eb7d959d6d25f5904e8c9ba946db7e1049a55","after":"033c7af671ec1c1a9e09c95a1c2a33758a7615f7","ref":"refs/heads/master","pushedAt":"2024-05-07T15:39:43.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"},"commit":{"message":"Update to latest bgfx.cmake (#1377)\n\nSee https://forum.babylonjs.com/t/pixel-8-pro-crash/48956. Specifically,\r\nthe fix that makes the code work is\r\nhttps://github.com/bkaradzic/bgfx/pull/3187.\r\n\r\nThis change also:\r\n- Cleans up the Android build such that the build output goes to the\r\n`Build/Android` folder.\r\n- Update CI to latest Xcode since the old compilers no longer compile\r\nwith latest bgfx.","shortMessageHtmlLink":"Update to latest bgfx.cmake (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2276716168\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1377\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1377/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1377\">#1377</a>)"}},{"before":"2ced80770d7366caffa105f03f01269aa0ff577e","after":"909eb7d959d6d25f5904e8c9ba946db7e1049a55","ref":"refs/heads/master","pushedAt":"2024-05-06T22:35:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"},"commit":{"message":"Support iOS17+ and macOS14+ (#1249)\n\n- Add job with xcode15/ios17\r\n- `AVCaptureVideoOrientation` is deprecated in newer targets. Replaced\r\nwith an enum when targeting iOS17+ or macOS14+.\r\n\r\nFixes #1248\r\n\r\n---------\r\n\r\nCo-authored-by: Gary Hsu <bghgary@users.noreply.github.com>","shortMessageHtmlLink":"Support iOS17+ and macOS14+ (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1782458489\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1249\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1249/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1249\">#1249</a>)"}},{"before":"19c01a5e5d1cffcb5e6dd3b3df5ecd6876f811be","after":null,"ref":"refs/heads/u/ryantrem/readme-vs2022sln","pushedAt":"2024-04-19T16:20:36.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"}},{"before":null,"after":"19c01a5e5d1cffcb5e6dd3b3df5ecd6876f811be","ref":"refs/heads/u/ryantrem/readme-vs2022sln","pushedAt":"2024-04-19T16:17:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ryantrem","name":"Ryan Tremblay","path":"/ryantrem","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5084643?s=80&v=4"},"commit":{"message":"Update SPIRV-Cross to latest to fix UWP warning (#1372)","shortMessageHtmlLink":"Update SPIRV-Cross to latest to fix UWP warning (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2209482075\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1372\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1372/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1372\">#1372</a>)"}},{"before":"e204ba7904d5ebeb803294a7407b59129ef61891","after":"2ced80770d7366caffa105f03f01269aa0ff577e","ref":"refs/heads/master","pushedAt":"2024-04-19T15:53:18.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"},"commit":{"message":"Fix Duplicate Import (#1375)","shortMessageHtmlLink":"Fix Duplicate Import (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2245634187\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1375\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1375/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1375\">#1375</a>)"}},{"before":"19c01a5e5d1cffcb5e6dd3b3df5ecd6876f811be","after":"e204ba7904d5ebeb803294a7407b59129ef61891","ref":"refs/heads/master","pushedAt":"2024-04-10T17:32:00.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"docEdub","name":"Drew Fillebrown","path":"/docEdub","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78323754?s=80&v=4"},"commit":{"message":"Use new JsRuntimeHost `BABYLON_API` calling convention macro (#1374)\n\nWithout explicit calling convention modifers, consumers are required to\r\ncompile with the same calling convention used in the released binaries.\r\nIf a consumer compiles with the `__stdcall` calling convention, the\r\nlinker won't resolve the function calls because the released binaries\r\nare built with the default `__cdecl` calling convention.\r\n\r\nThis change fixes the issue using an overridable `BABYLON_API` macro\r\ndefined as `__cdecl` by default on Windows platforms or defined as empty\r\non non-Windows platforms.\r\n\r\nSee also https://github.com/BabylonJS/JsRuntimeHost/pull/86.","shortMessageHtmlLink":"Use new JsRuntimeHost <code>BABYLON_API</code> calling convention macro (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2236068358\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1374\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1374/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1374\">#1374</a>)"}},{"before":"8674cbaf9514df6e221f49333fdc57da1539e4b2","after":"19c01a5e5d1cffcb5e6dd3b3df5ecd6876f811be","ref":"refs/heads/master","pushedAt":"2024-03-26T23:05:58.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"PolygonalSun","name":"Dave","path":"/PolygonalSun","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/50599569?s=80&v=4"},"commit":{"message":"Update SPIRV-Cross to latest to fix UWP warning (#1372)","shortMessageHtmlLink":"Update SPIRV-Cross to latest to fix UWP warning (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2209482075\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1372\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1372/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1372\">#1372</a>)"}},{"before":"9bf88d90aeb3cfa7ab05f94fb24b9f53cf5fd6ef","after":"8674cbaf9514df6e221f49333fdc57da1539e4b2","ref":"refs/heads/master","pushedAt":"2024-03-26T15:51:44.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"},"commit":{"message":"Bring in latest JsRuntimeHost with V8 inspector fixes (#1371)\n\nAlso includes various testing fixes","shortMessageHtmlLink":"Bring in latest JsRuntimeHost with V8 inspector fixes (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2201329927\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1371\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1371/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1371\">#1371</a>)"}},{"before":"8d61e153094c147ecb3979e20ce4c4a914048dd3","after":"9bf88d90aeb3cfa7ab05f94fb24b9f53cf5fd6ef","ref":"refs/heads/master","pushedAt":"2024-03-22T17:58:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"SergioRZMasson","name":"Sergio R. Z. Masson","path":"/SergioRZMasson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/97050577?s=80&v=4"},"commit":{"message":"Notify JS about bgfx restart (#1370)\n\nAdded an API no notify JS that the graphics context (bgfx) has been\r\nre-created. This API call will allow JS to re-create all GPU resources\r\naccordingly.","shortMessageHtmlLink":"Notify JS about bgfx restart (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2198111549\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1370\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1370/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1370\">#1370</a>)"}},{"before":"39ce2bca1f7cdaa43e5e9458c8f186059100b774","after":"8d61e153094c147ecb3979e20ce4c4a914048dd3","ref":"refs/heads/master","pushedAt":"2024-03-13T16:25:23.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"},"commit":{"message":"Rework vertex buffer code to handle non-normalized integer attributes correctly (#1369)\n\nRelated PR on the Babylon.js side:\r\nhttps://github.com/BabylonJS/Babylon.js/pull/14862\r\n\r\n- Add some visual tests that ensure interleaved buffers and updating\r\nbuffers work properly. See\r\n[playground](https://playground.babylonjs.com/#AVFNTW#5).\r\n- Add CesiumMan test which uses the same buffer for non-interleaved\r\nattributes.\r\n- Update playground runner script to support async `createScene`\r\nfunctions.\r\n- Update validation_native.js to support newer playgrounds, copied from\r\nJS visual test code.\r\n- Disable async shader compilation in validation (visual) tests.\r\n- Update Babylon.js package to 6.46.1 which includes changes from the PR\r\nnoted at the top.\r\n- Changed the `m_deviceId` and `m_deviceContext` to be more consistent\r\nwith all classes.\r\n- Modified the index and vertex buffer code to handle errors better.\r\n- Move all vertex buffer logic from vertex array into vertex buffer to\r\nkeep track of all promoted to float attributes.\r\n- Update vertex buffer logic to handle promote to float and keep track\r\nof the streams for setting and updating later.","shortMessageHtmlLink":"Rework vertex buffer code to handle non-normalized integer attributes…"}},{"before":"88d8f42289c24f9e38912a8c221ebf194fc70ba2","after":null,"ref":"refs/heads/ios-photo-fixes","pushedAt":"2024-03-09T00:59:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"ryantrem","name":"Ryan Tremblay","path":"/ryantrem","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5084643?s=80&v=4"}},{"before":"c453387300464a312c3a569084f198f88a98a8c4","after":"39ce2bca1f7cdaa43e5e9458c8f186059100b774","ref":"refs/heads/master","pushedAt":"2024-03-08T16:51:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"},"commit":{"message":"fix: cleanup view controller (#1368)\n\nThis PR cleans up view controller in iOS playground from explicit\r\nunwraps. It should give a better example of how people can use\r\nBabylonNative in their projects","shortMessageHtmlLink":"fix: cleanup view controller (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2174080097\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1368\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1368/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1368\">#1368</a>)"}},{"before":"4b5356f53e21dbd26e785e9032de6ebba5d193e1","after":"c453387300464a312c3a569084f198f88a98a8c4","ref":"refs/heads/master","pushedAt":"2024-03-04T18:08:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"SergioRZMasson","name":"Sergio R. Z. Masson","path":"/SergioRZMasson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/97050577?s=80&v=4"},"commit":{"message":"Allow device loss handle (#1366)\n\nAllow Babylon Native to properly handle bgfx shutdown and re-initialization.","shortMessageHtmlLink":"Allow device loss handle (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2162062707\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1366\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1366/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1366\">#1366</a>)"}},{"before":"b56aaae2f96a14da168021424260dc9ca899bc54","after":"4b5356f53e21dbd26e785e9032de6ebba5d193e1","ref":"refs/heads/master","pushedAt":"2024-02-27T21:28:41.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"ryantrem","name":"Ryan Tremblay","path":"/ryantrem","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5084643?s=80&v=4"},"commit":{"message":"Fix flash and image orientation for iOS image capture (#1363)\n\n`ImageCapture` was implemented for iOS a while back, but had a few\r\noutstanding bugs that are addressed in this PR:\r\n1. Flash modes were not working - there were actually two bugs here, the\r\nfirst being that we were trying to get supported flash modes from the\r\n`AVPhotoCaptureOutput` before we actually created the\r\n`AVPhotoCaptureOutput` (oops), and second there was a missing line to\r\nincrement the current index when populating the flash modes array.\r\n2. There was no code to deal with image rotation, so the created image\r\nwas always sideways (I believe based on the orientation of the physical\r\ncamera sensor relative to the orientation of the device).\r\n\r\nSo the changes here are to fix the issues of bullet 1 and add code for\r\nbullet 2.\r\n\r\nI also made some small changes to experience.js to reflect the missing\r\nsupport for invertY on Textures in BN which otherwise makes it confusing\r\nwhy the code is the way it is.\r\n\r\nEDIT: Regarding image rotation, I realized my fix for this was not\r\nreally correct. What actually happens with ImageCapture in the browser\r\n(at least in Chrome on Android), which is similar to what camera apps\r\ntypically do, is that the image data itself is not rotated when the\r\nphoto is taken. Rather, it just includes correct Orientation metadata\r\n(e.g. jpeg metadata), and code that reads that image is supposed to\r\nrespect the Orientation metadata. For example, the Photos app on iOS or\r\nWindows reads this metadata when loading a jpeg and does the rotation\r\nwhen displaying the image. Similarly, when a jpeg is used as a texture\r\nin Babylon.js, the loading path relies on the browser respecting the\r\nOrientation metadata when loading the image data. This means what really\r\nneeds to happen is:\r\n1. We need to ensure the correct Orientation metadata is included in\r\nphoto capture (achieved by the new change that sets\r\n`photoOutputConnection.videoOrientation`).\r\n2. We need the Babylon Native image parsing code path to respect the\r\nOrientation metadata, which bimg already gives us, we were just ignoring\r\nit (new change that rotates the image data during image parsing if\r\nneeded).","shortMessageHtmlLink":"Fix flash and image orientation for iOS image capture (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2149638622\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1363\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1363/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1363\">#1363</a>)"}},{"before":"3a5f72753c90b3c407d2bdeedef1370106112355","after":"88d8f42289c24f9e38912a8c221ebf194fc70ba2","ref":"refs/heads/ios-photo-fixes","pushedAt":"2024-02-27T20:30:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ryantrem","name":"Ryan Tremblay","path":"/ryantrem","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5084643?s=80&v=4"},"commit":{"message":"PR feedback","shortMessageHtmlLink":"PR feedback"}},{"before":"ae7c7f66d94e377d93c8b180103183a2f17c2576","after":"3a5f72753c90b3c407d2bdeedef1370106112355","ref":"refs/heads/ios-photo-fixes","pushedAt":"2024-02-27T19:55:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ryantrem","name":"Ryan Tremblay","path":"/ryantrem","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5084643?s=80&v=4"},"commit":{"message":"Handle Orientation metadata when loading images","shortMessageHtmlLink":"Handle Orientation metadata when loading images"}},{"before":"eb37014cf88d4f2a2257fc9de09cf776a83aa07d","after":"b56aaae2f96a14da168021424260dc9ca899bc54","ref":"refs/heads/master","pushedAt":"2024-02-27T19:20:14.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"CedricGuillemet","name":"Cedric Guillemet","path":"/CedricGuillemet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1312968?s=80&v=4"},"commit":{"message":"Up JSRuntimeHost (#1365)","shortMessageHtmlLink":"Up JSRuntimeHost (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2157273193\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1365\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1365/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1365\">#1365</a>)"}},{"before":"212dea6395fce705d4e72eb5dcdbfb16be593c35","after":"eb37014cf88d4f2a2257fc9de09cf776a83aa07d","ref":"refs/heads/master","pushedAt":"2024-02-23T14:56:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"docEdub","name":"Drew Fillebrown","path":"/docEdub","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/78323754?s=80&v=4"},"commit":{"message":"Fix CMake error occurring when JSRUNTIMEHOST_CORE_APPRUNTIME is set to `Off` (#1364)","shortMessageHtmlLink":"Fix CMake error occurring when JSRUNTIMEHOST_CORE_APPRUNTIME is set t…"}},{"before":"8aac1f8f8c13af3cf32b64fcb3ca846af806f22e","after":"ae7c7f66d94e377d93c8b180103183a2f17c2576","ref":"refs/heads/ios-photo-fixes","pushedAt":"2024-02-22T17:58:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ryantrem","name":"Ryan Tremblay","path":"/ryantrem","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5084643?s=80&v=4"},"commit":{"message":"Fix experience.js","shortMessageHtmlLink":"Fix experience.js"}},{"before":null,"after":"8aac1f8f8c13af3cf32b64fcb3ca846af806f22e","ref":"refs/heads/ios-photo-fixes","pushedAt":"2024-02-22T17:54:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"ryantrem","name":"Ryan Tremblay","path":"/ryantrem","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5084643?s=80&v=4"},"commit":{"message":"Fix flash\n\nRotate image as needed","shortMessageHtmlLink":"Fix flash"}},{"before":"56c3e3d002e057ade5948d0eedeebda0c080aa30","after":"212dea6395fce705d4e72eb5dcdbfb16be593c35","ref":"refs/heads/master","pushedAt":"2024-02-22T08:10:52.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"CedricGuillemet","name":"Cedric Guillemet","path":"/CedricGuillemet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1312968?s=80&v=4"},"commit":{"message":"up ndk and JSRuntimeHost (#1353)","shortMessageHtmlLink":"up ndk and JSRuntimeHost (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2120955127\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1353\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1353/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1353\">#1353</a>)"}},{"before":"ac372dfcf146339b803418e42aee2c20e65377d1","after":"56c3e3d002e057ade5948d0eedeebda0c080aa30","ref":"refs/heads/master","pushedAt":"2024-02-21T17:34:01.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bghgary","name":"Gary Hsu","path":"/bghgary","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/19158740?s=80&v=4"},"commit":{"message":"Update JsRuntimeHost to latest (#1362)\n\nBrings in build consistency fixes.","shortMessageHtmlLink":"Update JsRuntimeHost to latest (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2147255748\" data-permission-text=\"Title is private\" data-url=\"https://github.com/BabylonJS/BabylonNative/issues/1362\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/BabylonJS/BabylonNative/pull/1362/hovercard\" href=\"https://github.com/BabylonJS/BabylonNative/pull/1362\">#1362</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWUExPQA","startCursor":null,"endCursor":null}},"title":"Activity · BabylonJS/BabylonNative"}